[PATCH] D41315: [WebAssembly] Output functions individually

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added inline comments.


================
Comment at: wasm/InputSegment.h:38
 public:
-  InputSegment(const WasmSegment *Seg, const ObjFile *F)
+  InputSegment(const WasmSegment &Seg, const ObjFile &F)
       : Segment(Seg), File(F) {}
----------------
ncw wrote:
> Would you mind reverting this change (pointer to ref) before merging? I'd like to add a member `static InputSegment Discarded` (see ELF InputSection) - but that's awkward if the members are forced to be non-null. Ditto for InputFunction.
Actually - if we're switching to `isDiscarded` rather than `InputSegment::Discarded`, then the change from pointer to ref is fine. Sorry! I'll change the Comdat review to match.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41315