[PATCH] D41430: [ARM] Armv8-R DFB instruction

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMInstrInfo.td:4813
+                "dfb", "", []>,
+                Requires<[IsARM, HasDFB]> , Sched<[WriteALU]> {
+                let Inst{31-0} = 0xf57ff04c;
----------------
sdesmalen wrote:
> javed.absar wrote:
> > fhahn wrote:
> > > samparker wrote:
> > > > fhahn wrote:
> > > > > Are you sure about `Sched<[WriteALU]>`? It's an alias to the `DSB` instruction , which does not have a similar `Sched`
> > > > I'm not, but couldn't find where/how DSB got its scheduling info. Do you know where its defined? I should probably also add an InstAlias to DSB...
> > > The instruction is marked as having (unmodelled) side effects. That should tell the scheduler to not move instructions past this instruction, so I think there is no need to add scheduling info.
> > As this is memory relate WriteLd may be a better option (and probably more realistic in terms of timing generally). 
> Having an InstAlias to DSB instead of a new instruction allows you to reuse the original instruction definition (and not have to worry about scheduling models).
> TableGen usually errors when it finds a collision in instruction encodings, so I'm surprised it doesn't for this case (i.e. this instruction would collide with DSB instruction with immediate #0xc). 
Yes, cheers, this is what I'm doing instead.


================
Comment at: test/MC/Disassembler/ARM/dfb-arm.txt:1
+# SDCOMP-27699: DFB on ARMv8-R
+# RUN: llvm-mc -disassemble -triple armv8-none-eabi -mcpu=cortex-r52 -show-encoding < %s | FileCheck %s --check-prefix=CHECK-DFB
----------------
fhahn wrote:
> Please remove SDCOMP-27699.
Thanks!


https://reviews.llvm.org/D41430