[PATCH] D41430: [ARM] Armv8-R DFB instruction

[Florian Hahn via Phabricator via llvm-commits]

fhahn added reviewers: fhahn, sdesmalen, rengolin.
fhahn added inline comments.


================
Comment at: lib/Target/ARM/ARM.td:89
+
+
 def FeatureAcquireRelease : SubtargetFeature<"acquire-release",
----------------
I would just use a single new line here.


================
Comment at: lib/Target/ARM/ARMInstrInfo.td:4813
+                "dfb", "", []>,
+                Requires<[IsARM, HasDFB]> , Sched<[WriteALU]> {
+                let Inst{31-0} = 0xf57ff04c;
----------------
Are you sure about `Sched<[WriteALU]>`? It's an alias to the `DSB` instruction , which does not have a similar `Sched`


================
Comment at: lib/Target/ARM/ARMInstrThumb2.td:3197
+                "dfb", "", []>,
+                Requires<[IsThumb, HasDFB]>, Sched<[WriteALU]> {
+                let Inst{31-0} = 0xf3bf8f4c;
----------------
Same comment about `Sched<[WriteALU]>`


https://reviews.llvm.org/D41430