[PATCH] D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops.

[Dinar Temirbulatov via Phabricator via llvm-commits]

dtemirbulatov added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:3707-3708
+
+  // Check that all non-alternative operations dominate at least
+  // one real vector operation.
+  if (S.IsNonAlt) {
----------------
ABataev wrote:
> ABataev wrote:
> > What is the `real vector operation`? And why do you need this check? You mean that it is allowed to have sequence `load, add`, but not `add ,load`? Why?
> Seems to me, what you need to fix is `setInsertPointAfterBundle` function rather than addinng|checking domination here.
Yes, thanks, I see the problem in setInsertPointAfterBundle function.


https://reviews.llvm.org/D28907