[llvm] r321148 - [X86] Add a missing return to combineGatherScatter after sucessful combine.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 19 22:44:50 PST 2017


Author: ctopper
Date: Tue Dec 19 22:44:50 2017
New Revision: 321148

URL: http://llvm.org/viewvc/llvm-project?rev=321148&view=rev
Log:
[X86] Add a missing return to combineGatherScatter after sucessful combine.

Not sure how to test this cause I think the worst that happens is that we don't revisit the node a second time to look for additional combines. We used UpdateNodeOperands so the updating the DAG work was already done.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=321148&r1=321147&r2=321148&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Tue Dec 19 22:44:50 2017
@@ -36258,6 +36258,7 @@ static SDValue combineGatherScatter(SDNo
     SmallVector<SDValue, 5> NewOps(N->op_begin(), N->op_end());
     NewOps[2] = Mask.getOperand(0);
     DAG.UpdateNodeOperands(N, NewOps);
+    return SDValue(N, 0);
   }
 
   // With AVX2 we only demand the upper bit of the mask.




More information about the llvm-commits mailing list