[PATCH] D41353: [InstCombine] Adjusting bswap pattern to the new masked shl canonization

[Hal Finkel via Phabricator via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1436
+  // C2 = 8 for i32).
+  // Note the different canonic forms for 'shl's and 'shr's. For each of them
+  // the canonic form is set such that the 'and' constants are minimal (the
----------------
canonic -> canonical


================
Comment at: lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1437
+  // Note the different canonic forms for 'shl's and 'shr's. For each of them
+  // the canonic form is set such that the 'and' constants are minimal (the
+  // 'and' is before the shift for 'shl' and after the shift for 'shr').
----------------
canonic -> canonical


Repository:
  rL LLVM

https://reviews.llvm.org/D41353