[PATCH] D41315: [WebAssembly] Output functions individually
Nicholas Wilson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 19 04:07:19 PST 2017
ncw added inline comments.
================
Comment at: wasm/InputSegment.h:38
public:
- InputSegment(const WasmSegment *Seg, const ObjFile *F)
+ InputSegment(const WasmSegment &Seg, const ObjFile &F)
: Segment(Seg), File(F) {}
----------------
Would you mind reverting this change (pointer to ref) before merging? I'd like to add a member `static InputSegment Discarded` (see ELF InputSection) - but that's awkward if the members are forced to be non-null. Ditto for InputFunction.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D41315
More information about the llvm-commits
mailing list