[PATCH] D41380: [SCEV] Do not insert if it is already in cache

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 19 03:28:38 PST 2017


mkazantsev added a comment.

Do you mind giving the blocks in test some reasonable names? E.g. outer_loop, inner_loop etc, just to make it clear what is going on.



================
Comment at: test/Analysis/ScalarEvolution/truncate.ll:44
+; it expects that SCEV is not in the cache but it was added in recursive invocations.
+; So SCEV is in cache, Insertion Point is not update (remains nullptr) and we
+; get a crash when we insert SCEV into cache.
----------------
Nit: update -> updated


https://reviews.llvm.org/D41380





More information about the llvm-commits mailing list