[PATCH] D41277: Implement --just-symbols

[Chih-Mao Chen via Phabricator via llvm-commits]

PkmX updated this revision to Diff 127465.
PkmX added a comment.

Added a check to only allow `ET_EXEC` and the corresponding test.

On Tue, Dec 19, 2017 at 9:54 AM, Rafael Avila de Espindola <rafael.espindola at gmail.com> wrote:

> This patch allows --just-symbols to be a ET_DYN, ET_REL or ET_EXEC. Do
>  you need all 3? ET_REL in particular seems problematic since st_value
>  has a different meaning in relocatable files.
> 
> If you don't need ET_DYN or ET_REL, please reject them. If you need
>  them, please add a test.

`ld.bfd` accepts `ET_EXEC` and `ET_REL` but not `ET_DYN`. However I don't think this option makes much sense for `ET_REL` inputs so I'm restricting it to `ET_EXEC` for now.


https://reviews.llvm.org/D41277

Files:
  ELF/Driver.cpp
  ELF/InputFiles.cpp
  ELF/InputFiles.h
  ELF/Options.td
  ELF/SymbolTable.cpp
  test/ELF/Inputs/just-symbols.s
  test/ELF/just-symbols.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41277.127465.patch
Type: text/x-patch
Size: 6716 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171219/ce85dd8b/attachment.bin>