[PATCH] D41010: [orc][cmake] Check if 8 byte atomics require libatomic for unittest

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

I'm going to nitpick here a little. The patch is fine, but one of two things should change. Either line 29 should use `list(APPEND...)` instead of `set`, or you should do something more like:

  if(NOT HAVE_CXX_ATOMICS64_WITHOUT_LIB)
    set(ORC_TEST_ATOMIC_LIB atomic)
  endif()
  
  target_link_libraries(OrcJITTests PRIVATE ${LLVM_PTHREAD_LIB} ${ORC_TEST_ATOMIC_LIB})


https://reviews.llvm.org/D41010