[PATCH] D41300: [ARM] Fix PR35379 - incorrect unwind information when compiling with -Oz

[Ryan Prichard via Phabricator via llvm-commits]

rprichard added a comment.

I think "Diff 2" fixes the problem I found. The fix seems OK to me.



================
Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:1120
+        // corresponding stack slots.
+        if (MO.isUndef()) {
+          Pad += 4;
----------------
I wonder if we should assert that the registers to skip appear at the front of the instruction. e.g. Add an `assert(RegList.empty());` inside the `MO.isUndef()` block.


================
Comment at: test/CodeGen/ARM/PR35379.ll:41
+
+; Check that unwind info is the same even whetherw or not using -Os
+; (minsize attr)
----------------
typo in "... same even whetherw or not ..."


https://reviews.llvm.org/D41300