vsk added a comment. Sorry this slipped through the cracks. It's OK to ping patches weekly to make sure they get attention. This patch generally looks good. Could you add a test and source context? Repository: rL LLVM https://reviews.llvm.org/D34499