[PATCH] D41231: [Support][CachePruning] Fix regression that prevents disabling of pruning

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 09:48:03 PST 2017


tejohnson added a comment.

Just a couple of minor comments - thanks for adding the test. With those fixed it looks good from my perspective, but please wait for labath to sign off.



================
Comment at: include/llvm/LTO/legacy/ThinLTOCodeGenerator.h:159
+          CacheOptions.Policy.Interval = Interval > 0 ? std::chrono::seconds(Interval)
+          : std::chrono::seconds::max();
   }
----------------
The indentation looks a little funky to me here - can you run through clang-format?


================
Comment at: tools/lto/lto.cpp:576
                                                 int interval) {
-  return unwrap(cg)->setCachePruningInterval(interval);
+  return unwrap(cg)->setCachePruningInterval(interval );
 }
----------------
extra whitespace


https://reviews.llvm.org/D41231





More information about the llvm-commits mailing list