[PATCH] D41348: [ARM] Lower unsigned saturation to USAT
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 18 04:58:07 PST 2017
fhahn added a comment.
Thanks for the patch! Please upload a diff with more context: http://llvm.org/docs/Phabricator.html#id3 as this makes it easier to have a look at the code around your changes.
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:4286
if (!UpperCheckOp || !LowerCheckOp || LowerCheckOp == UpperCheckOp)
- return false;
+ {dbgs() << "Out 1\n";
+ return false;}
----------------
left over debug output
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:4312
K = (uint64_t)PosVal; // At this point, PosVal is guaranteed to be positive
+
return true;
----------------
nit: unrelated whitespace change.
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:12951
return false;
-
+
Offset = Op->getOperand(1);
----------------
nit: unrelated change
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:12957
}
-
+
bool isInc;
----------------
nit: unrelated change
https://reviews.llvm.org/D41348
More information about the llvm-commits
mailing list