[PATCH] D39888: [Sanitizers, LSan, Darwin] Provide fallback definition of VM_MEMORY_OS_ALLOC_ONCE

[Rainer Orth via Phabricator via llvm-commits]

ro added a comment.

In https://reviews.llvm.org/D39888#926171, @ro wrote:

> In https://reviews.llvm.org/D39888#926120, @kubamracek wrote:
>
> > // Before Xcode 4.5, the Darwin linker doesn't reliably support undefined
> >  // weak symbols.  Mac OS X 10.9/Darwin 13 is the first release only supported
> >  // by Xcode >= 4.5.
> >  #elif SANITIZER_MAC && \
> >
> >   __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ >= 1090 && !SANITIZER_GO
> >
> >   Can you explain? Is this the same problem? Another problem? If it's not specific to LSan then please move to a separate patch.
>
>
> This is a separate problem indeed, which I hit only after some workaround for the first was in place.  Between the previous and current
>  import of libsanitizer into gcc, the sanitizer code started to assume that undefined weak symbols work on OS X, which isn't true for
>  older versions.


I've now created https://reviews.llvm.org/D39888 for this.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D39888