[PATCH] D40782: [tablegen] Make strconcat return code if all arguments are code

Johannes Altmanninger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 00:57:43 PST 2017


johannes added a comment.

I use a different approach now, WDYT?



================
Comment at: lib/TableGen/Record.cpp:766
 
-static StringInit *ConcatStringInits(const StringInit *I0,
-                                     const StringInit *I1) {
+template <class T> static T *ConcatStringInits(const T *I0, const T *I1) {
   SmallString<80> Concat(I0->getValue());
----------------
hfinkel wrote:
> Maybe call this ConcatStringLikeInits or ConcatInits? It should be renamed now that it is not specific to StringInits.
yeah, makes sense, done


https://reviews.llvm.org/D40782





More information about the llvm-commits mailing list