[PATCH] D41330: [X86] Reduce Store Forward Block issues in HW

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

Few style comments. I didn't look at the algorithm closely yet.



================
Comment at: lib/Target/X86/X86FixupSFB.cpp:120
+  switch (LdOpcode) {
+  case X86::MOVUPSrm:
+  case X86::MOVAPSrm:
----------------
What about the EVEX versions of these instructions?


================
Comment at: lib/Target/X86/X86FixupSFB.cpp:221
+    return MOV128SZ;
+  case (X86::MOV64mr):
+  case (X86::MOV64mi32):
----------------
Remove the parentheses here.


================
Comment at: lib/Target/X86/X86FixupSFB.cpp:244
+// keep the core busy.
+#define LIMIT 20
+static SmallVector<MachineInstr *, 2>
----------------
Use a "static const unsigned " variable instead of a #define.


================
Comment at: lib/Target/X86/X86FixupSFB.cpp:458
+
+  int64_t ldDisp1 = LdDispImm;
+  int64_t ldDisp2 = 0;
----------------
Capitalize variable names.


Repository:
  rL LLVM

https://reviews.llvm.org/D41330