[PATCH] D41277: Implement --just-symbols

[Chih-Mao Chen via Phabricator via llvm-commits]

PkmX marked 3 inline comments as done.
PkmX added inline comments.


================
Comment at: ELF/Driver.cpp:183
 
+  if (JustSymbols) {
+    Files.push_back(createJustSymbolsFile(MBRef));
----------------
ruiu wrote:
> You can just call `Files.push_back(createJustSymbolsFile(MBRef))` instead of calling `addFile`.
You are right. In retrospect I should've just call that instead of adding an extra argument to `addFile`.


================
Comment at: ELF/InputFiles.h:337
+  static bool classof(const InputFile *F) {
+    return F->kind() == InputFile::JustSymbolsKind;
+  }
----------------
ruiu wrote:
> Remove `InputFile::`.
The `InputFile::` is required due to the rules of two-phase lookup in C++.


https://reviews.llvm.org/D41277