[PATCH] D41267: [LTO] Make processing of combined module more consistent

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

In https://reviews.llvm.org/D41267#957496, @mehdi_amini wrote:

> In https://reviews.llvm.org/D41267#957237, @vitalybuka wrote:
>
> > In https://reviews.llvm.org/D41267#957200, @mehdi_amini wrote:
> >
> > > > However small changes in input, could trigger combined module and shuffle outputs making life of llvm::LTO harder.
> > >
> > > Sorry but this is still loaded in assumption about the client, which seems dubious in general to me.
> >
> >
> > At this point I am trying to solve problem is the gold plugin, however I'd expect this could be helpful for other clients as well.
> >  Anyway why benefit of particular client without regressing behavior for the rest is a problem? Especially considering that the patch simplify implementation.
>
>
> That a problem because it is a terrible way in general to design complex system: this is a sign of over-coupling components and leaking abstractions through implicit API contract.


I agree that implicit contract about streams order is not nice here, and we should consider to make it explicit.


Repository:
  rL LLVM

https://reviews.llvm.org/D41267