[PATCH] D41310: [COFF] Clean up debug option handling

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 16:18:52 PST 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/COFF/debug-dwarf.test:4
+# RUN: lld-link /debug /entry:main /out:%t.exe %p/Inputs/ret42.obj
+# RUN: ls %t.pdb
+
----------------
smeenai wrote:
> ruiu wrote:
> > Is it guaranteed that ls exits with a non-zero value if a given file does not exist?
> I'm basing this on the existing nopdb.test. The same pattern is also used in pdb-options.test.
Thanks. Then it should be fine as it's already tested.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41310





More information about the llvm-commits mailing list