[PATCH] D41212: [llvm-objcopy] Add option to add a progbits section from a file

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 13:36:10 PST 2017


jakehehrlich updated this revision to Diff 127189.
jakehehrlich added a comment.

I agree on the points about replacement and about not following what GNU objcopy does on duplicate sections.

1. Added test to show that you can replace a section using --remove-section and --add-section
2. Moved the AddSection code to after section removal.


Repository:
  rL LLVM

https://reviews.llvm.org/D41212

Files:
  test/tools/llvm-objcopy/add-section-remove.test
  test/tools/llvm-objcopy/add-section.test
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h
  tools/llvm-objcopy/llvm-objcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41212.127189.patch
Type: text/x-patch
Size: 6471 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171215/10b07d37/attachment.bin>


More information about the llvm-commits mailing list