[PATCH] D36351: [lld][ELF] Add profile guided section layout

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/CallGraphSort.cpp:58-59
+namespace {
+using NodeIndex = std::ptrdiff_t;
+using EdgeIndex = std::ptrdiff_t;
+
----------------
nit: move this out of the anonymous namespace.


================
Comment at: lld/ELF/CallGraphSort.cpp:194-196
+    } else
+      Edges[EI].Weight = SaturatingAdd(Edges[EI].Weight, Weight);
+
----------------
This means that an input file could contain more than one line for the same from-to symbol pair. But does that actually happen?


https://reviews.llvm.org/D36351