[PATCH] D41252: [COFF] Set the IMAGE_DLL_CHARACTERISTICS_NO_SEH flag automatically

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D41252#957049, @rnk wrote:

> In https://reviews.llvm.org/D41252#957037, @mstorsjo wrote:
>
> > Only set the flag on x86.
>
>
> Can you confirm that this is consistent with MSVC? If so, looks good!


Yes, confirmed that MSVC only sets it on x86.



================
Comment at: COFF/Writer.cpp:692
+  if (!SEHTable && !Symtab->findUnderscore("_load_config_used") &&
+      Config->Machine == I386)
+    PE->DLLCharacteristics |= IMAGE_DLL_CHARACTERISTICS_NO_SEH;
----------------
rnk wrote:
> nit: I'd test the Machine first to short-circuit out of the symbol lookup for x64.
Will do before pushing.


https://reviews.llvm.org/D41252