[PATCH] D41274: [LTO] NFC: remove unique_ptr from some LTO::RegularLTOState members

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 11:02:58 PST 2017


pcc added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/SplitModule.h:37
 void SplitModule(
-    std::unique_ptr<Module> M, unsigned N,
+    Module &M, unsigned N,
     function_ref<void(std::unique_ptr<Module> MPart)> ModuleCallback,
----------------
Sorry, I forgot about the fact that this function takes a `unique_ptr`. In that case it would probably be fine to leave the `CombinedModule` field as a `unique_ptr` but just move its initialization to the constructor.


https://reviews.llvm.org/D41274





More information about the llvm-commits mailing list