[PATCH] D41090: [DWARFv5] Dump MD5 checksum from line-table header

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

sgtm. some formatting comments inline.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DIE.cpp:780
   case dwarf::DW_FORM_block:  Asm->EmitULEB128(Size); break;
+  case dwarf::DW_FORM_data16:
+    break;
----------------
for consistency with the surrounding code, perhaps all on one line?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DIE.cpp:797
+  case dwarf::DW_FORM_data16:
+    return 16;
   default: llvm_unreachable("Improper form for block");
----------------
same here?


https://reviews.llvm.org/D41090