[PATCH] D41235: [DAGCOmbine] Ensure that (brcond (setcc ...)) is handled in a canonical manner.
Nirav Dave via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 15 08:56:45 PST 2017
niravd added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:7014
+
+ return Combined;
}
----------------
Should this be "return SDValue();"?
================
Comment at: test/CodeGen/X86/live-out-reg-info.ll:15
+; CHECK-NEXT: movl %edi, %eax
+; CHECK-NEXT: shrl $23, %eax
+; CHECK-NEXT: testb $1, %ah
----------------
It looks like all the bittest patterns are no longer being matched because of the DAG change.
https://reviews.llvm.org/D41235
More information about the llvm-commits
mailing list