[PATCH] D40146: [JumpThreading] Preservation of DT and LVI across the pass

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

In https://reviews.llvm.org/D40146#956763, @brzycki wrote:

> In https://reviews.llvm.org/D40146#955920, @kuhar wrote:
>
> > Which files and includes formed the cycle? There are a lot of files that require dominators.h, and I'm not convinced adding a new class to is a good idea, given that it currently has just one user.
>
>
> @kuhar would it help if I put all the larger functions in Dominators.cpp to prevent aggressive inlining? That would make it a relatively small class.


That sounds better.

I wonder what caused the original cycle. I'm not entirely sure how modules are built, but have you tried getting rid of the include in Local.h? If that's not enough to break the cycle, I don't have any idea better than yours.


https://reviews.llvm.org/D40146