[PATCH] D40363: [AArch64][SVE] Asm: Improve diagnostics further when +sve is not specified

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:2800
 
   // Emit check that the required features are available.
   OS << "    // check if the available features match\n";
----------------
fhahn wrote:
> I think we should clarify here who's responsibility is to print the error message when ParseForAllFeatures = true.
> 
>  Also, `    if (!ParseForAllFeatures && (AvailableFeatures & it->RequiredFeatures!= it->RequiredFeatures) {`?
> 
I don't think it is necessary to explain that here, as this code is strictly about parsing of the operands.


https://reviews.llvm.org/D40363