[PATCH] D41113: [LLVMgold] Don't set resolutions for undefined symbols to 'Prevailing'
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 15 06:52:15 PST 2017
tejohnson added inline comments.
================
Comment at: llvm/trunk/lib/LTO/LTO.cpp:420
+ if (Res.Prevailing) {
+ assert((GlobalRes.IRName.empty() || !Sym.getIRName().empty()) &&
+ "Overriding existing resolution with undefined asm symbol");
----------------
I had suggested changing this to simply:
assert(GlobalRes.IRName.empty() && "....
since we should only have one prevailing def. Can you do that?
Repository:
rL LLVM
https://reviews.llvm.org/D41113
More information about the llvm-commits
mailing list