[PATCH] D40723: [MemCpyOpt] Perform call slot optimizations through GEPs

Björn Steinbrink via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 01:52:59 PST 2017


dotdash added a comment.

In https://reviews.llvm.org/D40723#955555, @rnk wrote:

> I think you could split this up and write more targetted tests. The sret change needs a test and is probably separable.


I didn't realize that phabricator only displays the list of commits, but provides no access to the individual diffs.

So I should submit the fixes incrementally in multiple, sequential review requests, right?


https://reviews.llvm.org/D40723





More information about the llvm-commits mailing list