[PATCH] D41273: [cmake] Remove redundant check for Targets to build

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 00:15:13 PST 2017


asb added a comment.

I have the same concern with this as I described in the discussion around r320413 <http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20171211/509800.html>.

With this change, I can directly specify an experimental backend using -DLLVM_TARGETS_TO_BUILD and it will "just work". I think there is value in requiring experimental backends to be specified separately with -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD. It means that anyone auditing the build configuration can see at a glance when an experimental backend is being built, which I think is important given the lack of stability guarantees for these backends. Did you intend that change in behaviour?


https://reviews.llvm.org/D41273





More information about the llvm-commits mailing list