[PATCH] D36351: [lld][ELF] Add profile guided section layout

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 18:01:22 PST 2017


ruiu added a comment.

> This needs to be implemented in the linker because of the line:
> 
>   if (From.Size + To.Size > Target->PageSize)
>     continue;
>    
> 
> This is responsible for doubling the performance improvement on a game. Implementing this outside of the linker requires implementing most of the linker, including LTO.

And function sizes cannot be retrieved from the instrumented build (because instrumentation changes function size), so it must be computed at link-time. Is this correct?


https://reviews.llvm.org/D36351





More information about the llvm-commits mailing list