[PATCH] D40802: [MemDep] Don't use cached results from a previous larger query

[Hal Finkel via Phabricator via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.

LGTM

This is a pretty awful implicit contract. Hopefully, we'll update this pass to use MemorySSA soon.



================
Comment at: lib/Transforms/Scalar/MemCpyOptimizer.cpp:495
+    // Create the memset after removing the stores, so that if there any cached
+    // non-local dependencies on the removed instructions, the cache entries
+    // are updated to "dirty" entries pointing below the memset, so subsequent
----------------
Please include the fact that you're talking about MemDep here, such as:

... on the removed instructions in MemoryDependenceAnalysis, the...


Repository:
  rL LLVM

https://reviews.llvm.org/D40802