[PATCH] D40751: [ICP] Expose unconditional call promotion interface

[David Li via Phabricator via llvm-commits]

davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

there are two small suggestions. otherwise LGTM



================
Comment at: include/llvm/Transforms/Utils/CallPromotionUtils.h:36
+/// bitcast instructions are inserted where appropriate.
+void promoteCall(CallSite CS, Function *Callee);
+
----------------
Perhaps return the callInstruction and perhaps a third optional pointer parameter to store the bitcast created.


================
Comment at: lib/Transforms/Utils/CallPromotionUtils.cpp:424
   // Return the new direct call.
   return NewInst;
 }
----------------
let NewInst = promoteCall(...)  instead of implicitly assume the same instruction gets converted.


https://reviews.llvm.org/D40751