[PATCH] D39956: [IR] Add MDBuilder helpers for the new TBAA metadata format

[Hal Finkel via Phabricator via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: include/llvm/IR/MDBuilder.h:153
     uint64_t Size;
-    MDNode *TBAA;
-    TBAAStructField(uint64_t Offset, uint64_t Size, MDNode *TBAA) :
-      Offset(Offset), Size(Size), TBAA(TBAA) {}
+    MDNode *Type;
+    TBAAStructField(uint64_t Offset, uint64_t Size, MDNode *Type) :
----------------
kosarev wrote:
> We refer to this field in clang's CodeGenTBAA::getBaseTypeInfoHelper(), so I should either fix that function just after committing this patch (and then the first commit won't be buildable) or commit a series of changes so that every revision is buildable. Say, I could temporarily add a getType() method, then switch getBaseTypeInfoHelper() to use it, then rename the field, then fix getBaseTypeInfoHelper() to refer to the new name and then remove getType(). Can you please advice on what way is preferred and whether it would be okay to do that without pre-review?
You can commit this patch immediately followed by an update to Clang. You'll still trip some of the buildbots, but in the present configuration, that's acceptable. 


https://reviews.llvm.org/D39956