[PATCH] D41234: [ELF] Fix placement of a sentinel entry in the .ARM.exidx section.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 14:40:55 PST 2017


ruiu added inline comments.


================
Comment at: ELF/OutputSections.h:85
 
-  void addSection(InputSection *IS);
+  void addSection(InputSection *IS, InputSectionDescription *Hint = nullptr);
 
----------------
I don't think we should change this function just fixing an edge case for .ARM.exidx and linker script. Isn't there any way that is less intrusive? Also, please avoid using a parameter with a default value in lld as much as possible.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41234





More information about the llvm-commits mailing list