[PATCH] D41152: Use a custom container to reduce AFDO's memory usage by ~60%

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 14:10:39 PST 2017


davidxl added a comment.

I suggest making this a multiple stage change.

patch-1: change expensive map type to std::map to materialize memory savings quickly -- with the data you collected, it is quite safe to check it in
patch-2: TinyMap implementation patch
patch-3: Use TinyMap in samplePGO -- with incremental savings data collected.

Patch-2 needs more closer look by someone like Chandler.  Data from patch-3 or perhaps some other potential users can help justify patch-2.


https://reviews.llvm.org/D41152





More information about the llvm-commits mailing list