[PATCH] D41152: Use a custom container to reduce AFDO's memory usage by ~60%

George Burgess IV via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 13:58:44 PST 2017


george.burgess.iv updated this revision to Diff 127018.
george.burgess.iv marked 2 inline comments as done.
george.burgess.iv added a comment.

Addressed feedback; thanks!

Also, I made `FunctionSamplesMap`'s key a `std::string`, so this is as close to NFC as possible. Doing so is a bit pricey, but we're still left with a 50-55% memory reduction. If we want, we can swap to `StringRef` in its own CL.


https://reviews.llvm.org/D41152

Files:
  include/llvm/ADT/TinyAssociativeVector.h
  include/llvm/ProfileData/SampleProf.h
  lib/ProfileData/SampleProf.cpp
  lib/ProfileData/SampleProfWriter.cpp
  lib/Transforms/IPO/SampleProfile.cpp
  test/tools/llvm-profdata/sample-profile-basic.test
  unittests/ADT/CMakeLists.txt
  unittests/ADT/TinyAssociativeVectorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41152.127018.patch
Type: text/x-patch
Size: 20605 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171214/d45aee1c/attachment.bin>


More information about the llvm-commits mailing list