[PATCH] D40033: [NVPTX] Initial adaptation of MCAsmStreamer/MCTargetStreamer for debug info in Cuda.

[Justin Lebar via Phabricator via llvm-commits]

jlebar added inline comments.


================
Comment at: test/CodeGen/Mips/mips16ex.ll:6
 ;16-NEXT: .cfi_personality
+;16: [[TMP:.*]]:
+;16-NEXT: $func_begin0 = ([[TMP]])
----------------
ABataev wrote:
> ABataev wrote:
> > echristo wrote:
> > > For the record this change is the one I'm concerned about. I don't think it's desired to put the cfi directives before the symbol.
> > > 
> > > That said, I'm going to have to take a closer look.
> > Yes, I understand this. It is required in PTX to have `.loc` before `$func_begin` symbol, otherwise it emits incorrect debug info. At least, we can make this change only for Cuda.
> Eric, any news?
Proxying ecirhsto for a moment, since he's currently slammed with something else: Your suggestion of doing this just for CUDA would resolve a lot of the fears here.


https://reviews.llvm.org/D40033