[PATCH] D41256: Find many -Wsign-compare and -Wtautological-constant-compare warnings in clang-cl.

[Zachary Turner via Phabricator via llvm-commits]

zturner created this revision.
zturner added reviewers: rnk, craig.topper.
Herald added subscribers: aheejin, hiraditya, sbc100, javed.absar.

The latter class of warnings triggers on x86 builds where size_t is 4 bytes, so `x > numeric_limits<unsigned>::max()` is always false.  The former class of warnings mostly involves comparing enums to unsigned values, since enums are signed by default in the MSVC ABI.


https://reviews.llvm.org/D41256

Files:
  clang/lib/CodeGen/CGExpr.cpp
  llvm/include/llvm/BinaryFormat/COFF.h
  llvm/include/llvm/Object/COFF.h
  llvm/include/llvm/Object/ELFObjectFile.h
  llvm/include/llvm/Object/MachO.h
  llvm/include/llvm/Object/ObjectFile.h
  llvm/include/llvm/Object/RelocVisitor.h
  llvm/include/llvm/Object/Wasm.h
  llvm/lib/Analysis/InstructionSimplify.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/Object/COFFObjectFile.cpp
  llvm/lib/Object/MachOObjectFile.cpp
  llvm/lib/Object/WasmObjectFile.cpp
  llvm/lib/ProfileData/InstrProfReader.cpp
  llvm/lib/ProfileData/SampleProfReader.cpp
  llvm/lib/Support/ARMAttributeParser.cpp
  llvm/lib/Target/X86/X86ISelLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41256.127012.patch
Type: text/x-patch
Size: 14167 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171214/dbaff2bf/attachment.bin>