[PATCH] D41115: [LNT] Provide a way to reliably point to results page
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 14 11:42:58 PST 2017
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
This would indeed solve most of the pain with a small change.
I faintly remember having trouble with mysql when choosing IDs myself in another project. But I think the column was marked autoincrement back then which I think our ID column is, so let's go with this.
================
Comment at: lnt/server/db/testsuitedb.py:1003
- run = self.Run(machine, order, start_time, end_time)
+ new_id = existing_run_id if existing_run_id else None
+ run = self.Run(new_id, machine, order, start_time, end_time)
----------------
Isn't this the same as `new_id = existing_run_id` here?
https://reviews.llvm.org/D41115
More information about the llvm-commits
mailing list