[PATCH] D40967: [LLD][ELF] Remove Duplicate .ARM.exidx sections

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 10:37:05 PST 2017


Peter Smith via Phabricator <reviews at reviews.llvm.org> writes:


> +    // Remove the Sections we marked as duplicate earlier.
> +    if (!RemoveSections)
> +      continue;

RemoveSections is an optimization, no? I would leave it out of the first
version since I expect most programs have some sections that can be
merged, so it is optimizing the uncommon case.

LGTM with that.

Cheers,
Rafael


More information about the llvm-commits mailing list