[PATCH] D41231: [Support][CachePruning] Fix regression that prevents disabling of pruning

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 08:21:17 PST 2017


labath added a comment.

The max() value will overflow if you convert it to a more precise type (e.g., milliseconds). This is something that can easily happen even without you realising it (I haven't checked whether that happens here, but even if it's not, it can be introduced in the future).
I'd consider having a more explicit way of specifying that pruning is disabled (for example, in lldb we use `Optional<Duration>` for various timeouts, and then `llvm::None` means infinite timeout).


https://reviews.llvm.org/D41231





More information about the llvm-commits mailing list