[PATCH] D41234: [ELF] Fix placement of a sentinel entry in the .ARM.exidx section.

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

This looks sensible to me. One minor nit with the comment as the ABI does not mention a sentinel. We add it as some recent versions of libunwind depend on it being there (due to gold and ld.bfd generating one).



================
Comment at: ELF/Writer.cpp:1187
+
+    // ARM ABI requires .ARM.exidx to be terminated by some piece of data.
+    // We have the terminater synthetic section class. Add that at the end.
----------------
Strictly speaking the ABI doesn't require the .ARM.exidx to be terminated by a sentinel, but without one it does mean that the address range of the last entry would only be terminated by the end of the address space. Until recently libunwind depended on the presence of a sentinel. 


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41234