[PATCH] D40967: [LLD][ELF] Remove Duplicate .ARM.exidx sections

[Rafael Avila de Espindola via llvm-commits]

Peter Smith via Phabricator <reviews at reviews.llvm.org> writes:

> peter.smith added a comment.
>
> Comments from Rafael via [llvm-commits]
>
>> 
>> 
>>> +  struct ExidxEntry {
>>>  +    uint32_t Fn;
>>>  +    uint32_t Unwind;
>>>  +  };
>>>  +
>>>  +  // Get the last table Entry from the previous .ARM.exidx section.
>>>  +  const ExidxEntry PrevEntry = *reinterpret_cast<const ExidxEntry *>(
>>>  +      Prev->Data.data() + Prev->getSize() - sizeof(ExidxEntry));
>>>  +  if (IsExtabRef(PrevEntry.Unwind))
>>>  +    return false;
>> 
>> This is not safe in a big endian host, no?
>
> I've updated the structure to contain ulittle32_t to match the original introduction in https://reviews.llvm.org/D25127. I'm happy to do it another way if you'd prefer.

I think you forgot to upload th new patch.

Cheers,
Rafael