[PATCH] D41204: Inline a small function.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 13 15:42:55 PST 2017


sbc100 added inline comments.


================
Comment at: lld/trunk/ELF/InputFiles.cpp:609
+
+  InputSectionBase *Sec = this->Sections[SecIdx];
   uint8_t StOther = Sym->st_other;
----------------
Why is inlining this better?  Isn't it generally considered better for comprehension to have smaller, well-named functions?

Also, out of curiosity, why all use of  `this->` in this file?   Just a local coding style or some kind of ambiguity resolution?




Repository:
  rL LLVM

https://reviews.llvm.org/D41204





More information about the llvm-commits mailing list