[PATCH] D40333: Separate LoopTraversal and BreakFalseDeps out of ExecutionDomainFix into their own files

Marina Yatsina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 13 14:35:18 PST 2017


myatsina updated this revision to Diff 126843.
myatsina added a comment.
Herald added a subscriber: mgrang.

I've uploaded a new review here and in https://reviews.llvm.org/D40330.

Changed LoopTraversal to not be a pass, but rather a class which returns the BB order and other passes can then traverse and process the BBs.
Separated some logic to a ReachingDefAnalysis pass which is used by both BreakFalsDeps and ExecutionDomainFix.

Between review https://reviews.llvm.org/D40330 and this review of deparating the code to different files I did some refactoring which is NFC (changing data types, moving comments etc). If you want I can upload the refactoring for review as well.


https://reviews.llvm.org/D40333

Files:
  include/llvm/CodeGen/ExecutionDepsFix.h
  include/llvm/CodeGen/ExecutionDomainFix.h
  include/llvm/CodeGen/LoopTraversal.h
  include/llvm/CodeGen/Passes.h
  include/llvm/CodeGen/ReachingDefAnalysis.h
  lib/CodeGen/BreakFalseDeps.cpp
  lib/CodeGen/CMakeLists.txt
  lib/CodeGen/ExecutionDepsFix.cpp
  lib/CodeGen/ExecutionDomainFix.cpp
  lib/CodeGen/LoopTraversal.cpp
  lib/CodeGen/ReachingDefAnalysis.cpp
  lib/Target/ARM/ARMTargetMachine.cpp
  lib/Target/X86/X86TargetMachine.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40333.126843.patch
Type: text/x-patch
Size: 106834 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171213/86755937/attachment.bin>


More information about the llvm-commits mailing list