[llvm] r320635 - Remove redundant includes from lib/Target/ARM.

Mikhail Zolotukhin via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 13 14:23:12 PST 2017


> On Dec 13, 2017, at 1:42 PM, Friedman, Eli <efriedma at codeaurora.org> wrote:
> 
> On 12/13/2017 1:31 PM, Michael Zolotukhin via llvm-commits wrote:
>> Author: mzolotukhin
>> Date: Wed Dec 13 13:31:17 2017
>> New Revision: 320635
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=320635&view=rev
>> Log:
>> Remove redundant includes from lib/Target/ARM.
>> 
>> Modified: llvm/trunk/lib/Target/ARM/ARMMacroFusion.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMMacroFusion.cpp?rev=320635&r1=320634&r2=320635&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/ARM/ARMMacroFusion.cpp (original)
>> +++ llvm/trunk/lib/Target/ARM/ARMMacroFusion.cpp Wed Dec 13 13:31:17 2017
>> @@ -12,7 +12,6 @@
>>  //
>>  //===----------------------------------------------------------------------===//
>>  -#include "ARMMacroFusion.h"
>>  #include "ARMSubtarget.h"
>>  #include "llvm/CodeGen/MacroFusion.h"
>>  #include "llvm/CodeGen/TargetInstrInfo.h"
> 
> This isn't right; I mean, it might compile, but it isn't a good idea.
> 
> Please revert this bit, and make sure you aren't doing the same thing anywhere else.
Good catch, thanks! I found several more places like this and reverted the corresponding changes in r320648.

Michael
> 
> -Eli
> 
> -- 
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
> 



More information about the llvm-commits mailing list