[PATCH] D41188: Move Repl to SectionBase

[Rafael Ávila de Espíndola via Phabricator via llvm-commits]

rafael created this revision.
rafael added a reviewer: ruiu.
Herald added a subscriber: emaste.

It is currently in InputSectionBase. Only InputSections are used in ICF,  so Repl should be move to InputSection to clear the class hierarchy or like this patch does to SectionBase for convenience.

The convenience of having it on the base class is that we can just access the replacement without having to first check if it is an InputSection. It is a bit less code and a bit faster as some of this code is very hot.

I got up to 1.77% improvement in clang-gdb-index and no regressions according to lnt.


https://reviews.llvm.org/D41188

Files:
  ELF/InputSection.cpp
  ELF/InputSection.h
  ELF/Symbols.cpp
  ELF/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41188.126783.patch
Type: text/x-patch
Size: 3997 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171213/fd57134f/attachment.bin>