[PATCH] D41156: [cmake] Add support for case-sensitive Windows SDKs

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: cmake/platforms/WinMsvc.cmake:78-93
+# WINSDK_CASE_SENSITIVE:
+#   The Windows SDK headers and libraries are not case-correct. You can mount
+#   the SDK in a case-insensitive mount to work around this. Run the following
+#   commands to set the mount up, and then copy the SDK headers and libraries to
+#   the winsdk.icase folder and use *that* folder as the path when configuring
+#   CMake.
 #
----------------
Assuming that the vfs overlay works as you claim it does, is there any advantage to using the `WINSDK_CASE_SENSITIVE=NO` path?  Why would someone ever want to use ciopfs instead of the vfs overlay?  Would it be good enough to just say "If CMAKE_SYSTEM_NAME is not windows, use the overlay"?


https://reviews.llvm.org/D41156